Add upload_type to Project #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-chang
suggested changes
Jul 1, 2024
| @@ -145,8 +147,7 @@ def is_chat_evaluation(self) -> bool: | |||
| return self.media_type == MediaType.Conversational and self.editor_task_type == EditorTaskType.ModelChatEvaluation | |||
|
|
|||
| def is_auto_data_generation(self) -> bool: | |||
| return self.media_type == MediaType.LLMPromptCreation or self.media_type == MediaType.LLMPromptResponseCreation or self.is_chat_evaluation( | |||
| ) | |||
| return (self.upload_type == UploadType.Auto) is True | |||
There was a problem hiding this comment.
reduntant, return self.upload == UploadType.Auto
Also not sure if it's needed, maybe the field is good enough instead of needing a function
There was a problem hiding this comment.
this is what you get if you try to do it directly... our Field stuff is not real Bool. Also the method help to wrap it all and since I already have it in place, makes it work better
There was a problem hiding this comment.
@adrian-chang I have updated as you suggested... this lint warning is invalid, I have verified in code self.upload_type is an Enum, not a Field
vbrodsky
force-pushed
the
VB/add-project-upload-type
branch
from
3f1fdcc to
71e85c7
Compare
vbrodsky
force-pushed
the
VB/add-project-upload-type
branch
from
71e85c7 to
adfb744
Compare
adrian-chang
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces logic mirrored from the api in a custom method with an attribute set by the api directly. This makes it more reliable
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features